fix(xmind2xmindmark): fix indentation error when converting xmind to xmindmark #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
According to the xmindmark syntax documentation, the correct format for
.xmindmarktext should be:I use the command
xmindmark -f xmind example.xmindmarkto generate theexample.xmindfile, which is a valid.xmindfile.However, when I use the command
xmindmark from example.xmind, the generatedexample.xmindmarkcontent has the following format:$ xmindmark from example.xmind Central Topic - Main Topic 1 - Main Topic 2When I attempt to convert
example.xmindmarkback toexample.xmindusing thexmindmarkcommand, a parsing error occurs:$ xmindmark -f xmind example.xmindmark /Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/parser/mindmap.js:229 parentObject = parentObject.rootTopic || parentObject; ^ TypeError: Cannot read properties of undefined (reading 'rootTopic') at addTopic (/Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/parser/mindmap.js:229:33) at addLine (/Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/parser/mindmark.js:69:65) at /Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/parser/mindmark.js:146:62 at Array.forEach (<anonymous>) at createMapByXMindMark (/Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/parser/mindmark.js:146:46) at /Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/lib/xmindmark-to-xmind.js:34:64 at Generator.next (<anonymous>) at /Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/lib/xmindmark-to-xmind.js:8:71 at new Promise (<anonymous>) at __awaiter (/Users/{me}/.nvm/versions/node/v22.11.0/lib/node_modules/xmindmark/dist/src/lib/xmindmark-to-xmind.js:4:12)Root Cause: The indentation handling in
src/lib/xmind-to-xmindmark.tsis incorrect, causing the generatedexample.xmindmarkfile to deviate from the standard xmindmark syntax. Additionally, the original unit tests were also flawed.Solution
Modify the indentation logic in
src/lib/xmind-to-xmindmark.ts.